Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Stable Memory always use 64-bit addresses and stable64_* system API. #498

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Jul 1, 2024

SDK-1758

Description

The 32-bit stable memory API are deprecated. They will trap when the stable memory exceeds 4 GiB.

Now ic-cdk only provide Rust API which deal with 64-bit stable memory addresses.

How Has This Been Tested?

api/stable/tests.rs

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review July 1, 2024 15:21
@lwshang lwshang requested a review from a team as a code owner July 1, 2024 15:21
@lwshang lwshang merged commit 1a1cb07 into main Jul 1, 2024
19 checks passed
@lwshang lwshang deleted the lwshang/stable64 branch July 1, 2024 16:44
github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Oct 8, 2024
Relevant breaking changes from
[`ic-cdk`](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md):
1. [[0.15.0]]([0.15.0]): 
1. BREAKING: Stable Memory always use 64-bit addresses and stable64_*
system API. (dfinity/cdk-rs#498)
2. BREAKING: Add log_visibility to the management canister API types:
(dfinity/cdk-rs#497)
        - CanisterSettings
        - DefiniteCanisterSettings.
3.
[[0.13.3]](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md#0133---2024-05-10-yanked)
BREAKING: Add wasm_memory_limit to the management canister API types:
(dfinity/cdk-rs#483)
    - CanisterSettings
    - DefiniteCanisterSettings.

---------

Co-authored-by: IDX GitHub Automation <[email protected]>
nikolay-komarevskiy pushed a commit to dfinity/ic that referenced this pull request Oct 11, 2024
Relevant breaking changes from
[`ic-cdk`](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md):
1. [[0.15.0]]([0.15.0]): 
1. BREAKING: Stable Memory always use 64-bit addresses and stable64_*
system API. (dfinity/cdk-rs#498)
2. BREAKING: Add log_visibility to the management canister API types:
(dfinity/cdk-rs#497)
        - CanisterSettings
        - DefiniteCanisterSettings.
3.
[[0.13.3]](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md#0133---2024-05-10-yanked)
BREAKING: Add wasm_memory_limit to the management canister API types:
(dfinity/cdk-rs#483)
    - CanisterSettings
    - DefiniteCanisterSettings.

---------

Co-authored-by: IDX GitHub Automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants