Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: candid-extractor supports --version #485

Merged
merged 8 commits into from
Apr 22, 2024
Merged

feat: candid-extractor supports --version #485

merged 8 commits into from
Apr 22, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Apr 22, 2024 •
edited
Loading

Description

Use clap for CLI. So we get support for -V/--version and -h/--help automatically.

Also in this PR:

  • Add the changelog file for this bin crate.
  • Upgrade wasmtime dependency to v19.
    • Require more recent rust toolchain, so bump to v1.75 as the sdk repo.
  • cargo update to refresh the lock file.

Fixes #459

How Has This Been Tested?

Added a test in examples/print

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review April 22, 2024 15:58
@lwshang lwshang requested a review from a team as a code owner April 22, 2024 15:58
@lwshang lwshang merged commit 8620c0e into main Apr 22, 2024
19 checks passed
@lwshang lwshang deleted the lwshang/extractor_version branch April 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

candid-extractor --version
2 participants
@lwshang @ericswanson-dfinity