Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide safe wrapper of global_timer_set in ic-cdk #475

Merged
merged 3 commits into from
Mar 29, 2024
Merged

feat: provide safe wrapper of global_timer_set in ic-cdk #475

merged 3 commits into from
Mar 29, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Mar 29, 2024 •
edited
Loading

SDK-1544

Description

Though we provide a timers suite in ic-cdk-timers, it is still useful to call global_timer_set system API directly.
This PR adds the safe wrapper:

pub fn set_global_timer(timestamp: u64) -> u64;

How Has This Been Tested?

e2e test

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review March 29, 2024 17:18
@lwshang lwshang requested a review from a team as a code owner March 29, 2024 17:18
@lwshang lwshang merged commit a47fd6d into main Mar 29, 2024
17 checks passed
@lwshang lwshang deleted the lwshang/sdk-1544 branch March 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @ericswanson-dfinity