-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage/sql: use isolation level "serializable" for transactions #654
Merged
ericchiang
merged 3 commits into
dexidp:dev
from
ericchiang:dev-sql-optimistic-concurrency
Nov 1, 2016
Merged
storage/sql: use isolation level "serializable" for transactions #654
ericchiang
merged 3 commits into
dexidp:dev
from
ericchiang:dev-sql-optimistic-concurrency
Nov 1, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f5a455
to
1b85d23
Compare
ericchiang
commented
Nov 1, 2016
// Same error as Kubernetes. | ||
return errors.New("the object has been modified; please apply your changes to the latest version and try again") | ||
default: | ||
return fmt.Errorf("multiple rows updated: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, this is the wrong format string
0204d10
to
27f6464
Compare
wow, this works with kubernetes as well
|
27f6464
to
786e12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test this with the kubernetes third party resources.
closes #628
closes #600