Clean up LDAP Connector #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
force-pushed
the
ldap-groups
branch
5 times, most recently
from
b35c661 to
16b3ee0
Compare
|
Groups implementation added. Need to figure out how to have this work with refresh tokens (hopefully without too much refactoring). |
ericchiang
force-pushed
the
ldap-groups
branch
2 times, most recently
from
b51a22c to
c629cfa
Compare
ericchiang
changed the title
|
This PR has been changed to just include the cleanups to the LDAP connector. Ready for review. |
|
Woops, left some docs unfinished. |
|
Ready for review |
| (&(objectClass=person)(uid=janedoe)) | ||
| ``` | ||
|
|
||
| If the search finds an entry |
|
found a few minor things, otherwise LGTM |
|
👍 updated |
* Remove some unlikely to be used fields to help configurability.
* Combined "serverHost" and "serverPort" into "host"
* Remove "timeout" (just default to 30 seconds).
* Remove "maxIdleConn" will add it back if users feel the need
to control the number of cached connections.
* Remove "trustedEmailProvider" (just always trust).
* Remove "skipCertVerification" you can't make this connector
ingore TLS errors.
* Fix configs that don't search before bind (previously broken).
* Add more examples to Documentation
* Refactor LDAPPool Acquire() and Put() into a Do() function which
always does the flow correctly.
* Added more comments and renamed some functions.
* Moved methods on LDAPIdentityProvider to the LDAPConnector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit cleans up the LDAP connector a bit. A follow up one will add the groups implementation.
Cleanup includes:
to control the number of cached connections.
ingore TLS errors.
always does the flow correctly.
Edit: