Add authproxy preferred_username header #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kot <[email protected]>
kotx
force-pushed
the
authproxy-preferredUsername
branch
from
e44fb00 to
4512152
Compare
2 tasks
nabokihms
approved these changes
Feb 1, 2025
|
Looks good and straightforward. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows proxies to pass
X-Remote-User-Nameheader to set preferred username. Also adds tests.Perhaps authproxy should be extended to allow any claims, instead of adding headers for preferred username, picture, etc? But that's out of scope for this PR.
What this PR does / why we need it
Resolves #3876.
Special notes for your reviewer
Defaults to the value of
X-Remote-User(user name), to preserve the existing default. But we may want to change this because preferred username = shorthand, and user name = display name.