Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector/dingtalk):Add Alibaba Dingtalk connector #2914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linuxliker
Copy link

connector: implement Alibaba dingtalk connector
connector/dingtalk implements authorization strategy via Alibaba Dingtalk's DingTalk OAuth 2.0 API.
DingTalk OAuth 2.0 API: https://open.dingtalk.com/document/orgapp/sso-overview.

connector: implement Alibaba dingtalk connector
connector/dingtalk implements authorization strategy via Alibaba Dingtalk's DingTalk OAuth 2.0 API.
DingTalk OAuth 2.0 API: https://open.dingtalk.com/document/orgapp/sso-overview.

Signed-off-by: xiaojin.hxj <[email protected]>
@linuxliker
Copy link
Author

Also submit the doc PR here: dexidp/website#135

@linuxliker
Copy link
Author

@sagikazarmark hi,I resubmit this PR. And thank you for your review, these conditions are acceptable to me. And I add the documentation. Please help me review on this thread again, Thank you.

sagikazarmark's review in annother PR thread:
@linuxliker thank you for the contribution.

At the moment we are trying to limit the number of connectors we accept. Generally, these are the conditions under we accept new connectors:

The connector is marked as experimental and is not covered by the backward compatibility promise
We expect the submitter to answer issues and provide some level of support for the connector
Once we figure out how we support external connectors, the connector may be moved out of the core.
If these conditions are acceptable, we are happy to accept this connector.

We also kindly ask you that you send a PR to the website to add documentation.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant