Fixes https://github.com/dexidp/dex/issues/2537 #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivansh Vij <[email protected]>
Fixes #2537 Signed-off-by: Shivansh Vij <[email protected]>
nabokihms
approved these changes
May 30, 2022
|
Because our implementation is not compliant with the spec, I think we can accept the PR without worrying about being a breaking change. @ShivanshVij, good catch! Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivansh Vij [email protected]
Overview
What this PR does / why we need it
Closes #2537
This is a bug that was introduced in this PR, and is where the
handleDeviceCodehandler does not set thecontent-typeheader in the response toapplication/json- because of this, the flow does not conform to the RFC (https://datatracker.ietf.org/doc/html/rfc8628#section-3.3 and https://datatracker.ietf.org/doc/html/rfc6749#section-5.1).I've also added a test case to check for this exact bug.
Special notes for your reviewer
Does this PR introduce a user-facing change?