handlePasswordGrant: insert connectorData into OfflineSession #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using dex with the kubernetes oidc client results in the creation of an Offline Session with empty ConnectorData. This change will insert the ConnectorData from the initial Login into the OfflineSession, as already done in `handlePasswordLogin`. Not doing this results in failures to refresh a token. I've observed this with the ldap connetor, other connectors might be affected as well. The ldap connector will fail with this error message: `failed to refresh identity: ldap: failed to unmarshal internal data: unexpected end of JSON input` The `Refresh` method of the ldap connector will first try to unmarshal the ConnectorData, which was empty, as dex wouldn't store it in storage after a successful login. Signed-off-by: Henning Surmeier <[email protected]>
hensur
force-pushed
the
pass-connector-data
branch
from
8b06467 to
32904f3
Compare
|
Hello @hensur. Thanks, it looks good. I wonder if we can write a test for this? |
|
Hey @nabokihms! |
Signed-off-by: Henning Surmeier <[email protected]>
hensur
force-pushed
the
pass-connector-data
branch
from
36310a0 to
3b5e12b
Compare
nabokihms
reviewed
Jul 16, 2021
nabokihms
approved these changes
Jul 16, 2021
Signed-off-by: Henning Surmeier <[email protected]>
|
Thanks for your contribution @hensur ! |
nolem
pushed a commit
to macstab/dex-roles
that referenced
this pull request
Aug 8, 2021
…#2199) * handlePasswordGrant: insert connectorData into OfflineSession This change will insert the ConnectorData from the initial Login into the OfflineSession, as already done in handlePasswordLogin. Signed-off-by: Henning Surmeier <[email protected]> Signed-off-by: cschnapka <[email protected]>
6 tasks
elffjs
pushed a commit
to DIMO-Network/dex
that referenced
this pull request
Jun 27, 2022
…#2199) * handlePasswordGrant: insert connectorData into OfflineSession This change will insert the ConnectorData from the initial Login into the OfflineSession, as already done in handlePasswordLogin. Signed-off-by: Henning Surmeier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Using dex with the kubernetes oidc client results in the creation
of an Offline Session with empty ConnectorData.
This results in a working login, however, the ldap connector will fail once the client attempts to refresh its token.
This change will insert the ConnectorData from the initial Login
into the OfflineSession, as already done in
handlePasswordLogin.What this PR does / why we need it
Not doing this results in failures to refresh a token.
I've observed this with the ldap connetor, other connectors might
be affected as well.
The ldap connector will fail with this error message:
failed to refresh identity: ldap: failed to unmarshal internal data: unexpected end of JSON inputThe
Refreshmethod of the ldap connector will first try to unmarshalthe ConnectorData, which was empty, as dex wouldn't
store it in storage after a successful login.
Special notes for your reviewer
While this seems to fix the issue, I'm not sure if it is desired to save the ConnectorData in
handlePasswordGrantas done inhandlePasswordLogin.Does this PR introduce a user-facing change?