api: validate local connector existence before creating user #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobbyrullo and @joeatwork this one could definitely use a code review. |
This commit moves the user.Manage to its own package (user/manager) so it can import the connector package in a later commit. For clarity, it renames "Manager" to "UserManager" using gorname. This commit has no functional changes.
Add ConnectorConfigRepo to UserManager. When trying to create a RemoteIdentity, validate that the connector ID exists. Fixes dexidp#198
ericchiang
force-pushed
the
validate_connector
branch
from
a95f54a to
f43655a
Compare
|
@bobbyrullo For the second commit please look at the diff for |
|
LGTM++ |
bobbyrullo
added a commit
that referenced
this pull request
Dec 8, 2015
api: validate local connector existence before creating user
ericchiang
added a commit
to ericchiang/dex
that referenced
this pull request
Dec 8, 2015
Added missing err return introduced by dexidp#199
bcwaldon
added a commit
to bcwaldon/dex
that referenced
this pull request
Dec 10, 2015
db: drop connector cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a user, ensure the local connector ID held by the
overlord and worker match the ID of a local connector in the
database.
Fixes #198