Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gotemplate formatting for Dex config file #1965

Closed
wants to merge 1 commit into from

Conversation

nabokihms
Copy link
Member

Signed-off-by: m.nabokikh [email protected]

Overview

  • read config file as a template and execute it
  • add sprig function support
  • provide template configuration example

What this PR does / why we need it

An alternative of #1893
Instead of adding an external tool (dockerize), this PR introduces another approach.

Special notes for your reviewer

Does this PR introduce a user-facing change?

Add go template formatting support for Dex config file.

@sagikazarmark
Copy link
Member

I'm very much against this approach. This shouldn't be Dex's responsibility. Dockerize indeed seems to be a dead end, so I see two ways ahead:

@nabokihms
Copy link
Member Author

Just an example, we can close this PR after figuring out the right way.

@nabokihms
Copy link
Member Author

Personally, I'm more into gomplate, than rewriting dockerize (or rewriting anything).

  • arm packages
  • Crypto functions
  • YAML formatting function
  • Solid doccumentation

@sagikazarmark
Copy link
Member

I think we can close this in favor of #1893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants