Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add description templates #1852

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

nabokihms
Copy link
Member

Overview:
This PR adds issues templates and pull request template according to this documentation

What problem does it solve?:
Templates make it easier to maintain the project.

  • Bug report template will help with collecting the necessary information for debugging
  • Pull request and feature request templates will help people to think about why they open / would like to open a PR

Adding them will standardize the communication process between maintainers and users.

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sagikazarmark sagikazarmark merged commit 6fcd9b4 into dexidp:master Nov 5, 2020
@nabokihms
Copy link
Member Author

nabokihms commented Nov 5, 2020

It looks I misspelled the issue templates config name. It must be config.yml instead of config.yaml. My bad :(
PR templates work as expected. If it is possible I will prepare a fix for it.

@sagikazarmark
Copy link
Member

I fixed it. Looks like front matter is also missing from templates.

@nabokihms
Copy link
Member Author

Yes! Now it's a lot better :0

@sagikazarmark
Copy link
Member

Check again, pushed some additional changes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants