storage/sql: allow specifying sql flavor specific migrations #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonifaido
force-pushed
the
sql-specific-migrations
branch
from
3678cea to
c4c5fde
Compare
Signed-off-by: Nandor Kracser <[email protected]>
Signed-off-by: Nandor Kracser <[email protected]>
bonifaido
force-pushed
the
sql-specific-migrations
branch
from
c4c5fde to
c7e9960
Compare
sagikazarmark
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore increase
auth_request.statelength to 4096 in MySQL because JWT states can easily exceed the current limit and get cut, which causes weird login issues. Postgres and SQLite is not affected because they are usingTEXT.Fixes: #1658