add preffered_username to idToken #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonifaido
force-pushed
the
preferred_username
branch
from
6c6e58b to
c3d2fef
Compare
bonifaido
force-pushed
the
preferred_username
branch
from
c3d2fef to
81631a6
Compare
srenatus
reviewed
Oct 11, 2019
bonifaido
force-pushed
the
preferred_username
branch
from
33de397 to
ab10cb2
Compare
ghost
reviewed
Oct 22, 2019
|
Changes are done (as requested). |
ghost
approved these changes
Oct 23, 2019
|
I built a docker container of this branch and tested it (sqlite3 storage, LDAP provider). Works fine! |
|
Do you think we are okay to merge this @srenatus ? |
srenatus
approved these changes
Oct 30, 2019
Signed-off-by: Nandor Kracser <[email protected]>
bonifaido
force-pushed
the
preferred_username
branch
from
4757837 to
c1b421f
Compare
ghost
reviewed
Oct 30, 2019
Co-Authored-By: Felix Fontein <[email protected]>
|
Thanks a lot for implementing this! I'm already using it in production and this was something that was really missing (for me) :) |
|
Great to hear that, welcome! We also missed it, and will introduce it in prod in the coming days :) |
ghost
mentioned this pull request
5 tasks
ghost
mentioned this pull request
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nandor Kracser [email protected]
Implemented preferred_username in ID Token for:
TODO:
Fixes: #1076