Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return HTTP 400 for invalid state parameter #1490

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

momokatte
Copy link
Contributor

The state parameter is invalid, expired, or already consumed and this HTTP request should not be retried.

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This seems correct to me.

I wonder if there's value in adding a test case. What do you think? (Not meant as a suggestive question.)

@momokatte
Copy link
Contributor Author

I think there's value in testing some of that handler's error conditions, will submit a separate pull request for it before the weekend.

@srenatus
Copy link
Contributor

@momokatte would you mind rebasing the branch? It's got some merge commit in it right now that I'd rather not get into master 😃

@momokatte
Copy link
Contributor Author

Done, and sorry about the mess -- I have a better handle on this workflow now and will avoid making changes in my own master branch.

@srenatus srenatus merged commit d36e6c2 into dexidp:master Aug 2, 2019
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
Return HTTP 400 for invalid state parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants