Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return config validation errors in one go #1439

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Return config validation errors in one go #1439

merged 2 commits into from
Jul 30, 2019

Conversation

sks
Copy link

@sks sks commented Apr 29, 2019

  • Bulk Validate all the configuration
  • Added test case for validation.

Sample Output


Invalid Config:
	-	no issuer specified in config file
	-	no storage supplied in config file
	-	must supply a HTTP/HTTPS  address to listen on
exit status 2

Carry forward from #1264

@sks sks mentioned this pull request Apr 29, 2019
Closed
JoelSpeed
JoelSpeed requested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment below is fixed, I'm happy to get this merged

cmd/dex/config.go Show resolved Hide resolved
@sks sks force-pushed the feature/fail_on_invalid_config branch from 8e3951c to 6769a3b Compare July 23, 2019 15:17
bonifaido
bonifaido approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

JoelSpeed
JoelSpeed approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@JoelSpeed JoelSpeed merged commit e2ddeff into dexidp:master Jul 30, 2019
@sks sks deleted the feature/fail_on_invalid_config branch July 30, 2019 19:50
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
@JoelSpeed
Merge pull request dexidp#1439 from sks/feature/fail_on_invalid_config
ef6b7e8 
Return config validation errors in one go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sks @bonifaido @JoelSpeed