cmd/dex/serve.go: log static client name instead of ID #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Soubeyrand <[email protected]>
yann-soubeyrand
force-pushed
the
static-client-log-name
branch
from
0fcb91a to
c5f2871
Compare
yann-soubeyrand
changed the title
ericchiang
approved these changes
Apr 18, 2019
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…-name cmd/dex/serve.go: log static client name instead of ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
According to https://www.oauth.com/oauth2-servers/client-registration/client-id-secret/, client ID should not be easily guessable and many people use random hex strings. It's therefore easier to identify clients in logs using their name instead of their ID.