connectors/ldap: treat 'constraint violation' on bind as bad credentials #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
approved these changes
Sep 4, 2018
Some directory servers (I think it's Oracle) return
Constraint Violation: Exceed password retry limit. Account locked.
when attempting to login too many times. While constraint violation can
mean many things, we're checking this as an error on BIND, so it's
more likely that something like this has happened than any other thing.
Hence, we should treat it as an "incorrect password" situation, not an
internal error.
It would of course be preferrable to surface more information about this
precise error (and similar ones), but I think this is beyond this small
change.
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/ldap/treat-bind-constraint-violation-as-bad-login
branch
from
2d701b1 to
6a2d4ab
Compare
|
I feel like I'm skipping the queue, but since the change is quite minimal, I'll merge this. (A quick look around didn't reveal any low-hanging fruit in terms of improving test coverage for this, so, let's leave it at that.) |
srenatus
deleted the
sr/ldap/treat-bind-constraint-violation-as-bad-login
branch
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
…raint-violation-as-bad-login connectors/ldap: treat 'constraint violation' on bind as bad credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some directory servers (I think it's Oracle) return
when attempting to login too many times. While constraint violation can
mean many things, we're checking this as an error on BIND, so it's
more likely that something like this has happened than any other thing.
Hence, we should treat it as an "incorrect password" situation, not an
internal error.
It would of course be preferrable to surface more information about this
precise error (and similar ones), but I think this is beyond this small
change.
(This is some prior art: vesse/passport-ldapauth#21 )