add Refresh() to mock passwordConnector #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Jun 5, 2018
connector/mock/connectortest.go
Outdated
| @@ -112,3 +112,7 @@ func (p passwordConnector) Login(ctx context.Context, s connector.Scopes, userna | |||
| } | |||
|
|
|||
| func (p passwordConnector) Prompt() string { return "" } | |||
|
|
|||
| func (p passwordConnector) Refresh(ctx context.Context, s connector.Scopes, identity connector.Identity) (connector.Identity, error) { | |||
There was a problem hiding this comment.
[nit] if ctx and s aren't used, let's go with
func (p passwordConnector) Refresh(_ context.Context, _ connector.Scopes, identity connector.Identity) (connector.Identity, error) {
scotthew1
force-pushed
the
mock-connector-refresh
branch
from
5180dcb to
f8e0db6
Compare
srenatus
approved these changes
Jun 6, 2018
|
@srenatus any chance you're able to merge this now that the repo has moved? |
|
@scotthew1 I don't see why not, indeed. Just one more nitpick: Could you add something like _ connector.RefreshConnector = passwordConnector{}next to that one, since that's what the addition does, make the mock connector satisfy |
scotthew1
force-pushed
the
mock-connector-refresh
branch
from
f8e0db6 to
2707302
Compare
|
@srenatus updated. also rebased on master |
|
Status update? |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
add Refresh() to mock passwordConnector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've been using the mock passwordConnector for some internal testing, but it doesn't satisfy the
RefreshConnectorinterface. this change fixes that.