Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: expand connector docs and assign each a level of support #1168

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

ericchiang
Copy link
Contributor

@philips
Copy link

philips commented Jan 5, 2018

LGTM

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification question re: microsoft connector 👇

README.md Outdated
| [GitLab](Documentation/connectors/gitlab.md) | yes | yes | beta | |
| [OpenID Connect](Documentation/connectors/oidc.md) | yes | no ([#1065][issue-1065]) | beta | Includes Google, Salesforce, Azure, etc. |
| [LinkedIn](Documentation/connectors/linkedin.md) | yes | no | beta | |
| [Microsoft](Documentation/connectors/microsoft.md) | yes | no | beta | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the unconditional "no" to supports groups claims is accurate. Should this reference the docs caveat, maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right. It does support groups, my bad.

@ericchiang ericchiang merged commit f83c86c into dexidp:master Jan 5, 2018
@ericchiang ericchiang deleted the connector-docs branch January 5, 2018 17:27
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
README: expand connector docs and assign each a level of support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants