-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license: add bill of materials. #1152
Conversation
Makefile
Outdated
@@ -36,6 +36,8 @@ release-binary: | |||
revendor: | |||
@glide up -v | |||
@glide-vc --use-lock-file --no-tests --only-code | |||
@CGO_ENABLED=1 go get github.com/coreos/license-bill-of-materials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pin this instead of running go get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericchiang pin how?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned to a specific version instead of grabbing master every time. Either by vendoring the tool into Dex (what we do with the go proto generator) or by grabbing a release binary at a specific tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. There are no release binaries, so I'll figure out how to vendor it.
@ericchiang PTAL |
@diegs tried to run this locally. Looks like there's an additional dependency?
|
@ericchiang bumped the vendor with the fix. |
license: add bill of materials.
No description provided.