Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix proto build #1140

Merged
merged 3 commits into from
Dec 1, 2017
Merged

*: fix proto build #1140

merged 3 commits into from
Dec 1, 2017

Conversation

ericchiang
Copy link
Contributor

The proto build is currently using un-pinned dependencies. Pin them in the glide file and add travis tests to make sure this is checked during CI.

cc @rithujohn191

@ericchiang ericchiang force-pushed the fix-proto-build branch 3 times, most recently from 18ba9d1 to 286e7fa Compare December 1, 2017 01:02
Copy link
Contributor

@rithujohn191 rithujohn191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rithujohn191 rithujohn191 merged commit 32257bc into dexidp:master Dec 1, 2017
@ericchiang ericchiang deleted the fix-proto-build branch December 1, 2017 22:03
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants