Implement Microsoft (Azure AD) connector #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Nov 23, 2017
Documentation/microsoft-connector.md
Outdated
| logged in user, an explicit organization administrator consent is required. To | ||
| obtain the consent do the following: | ||
|
|
||
| - when registering dex application on [https://apps.dev.microsoft.com]() add |
There was a problem hiding this comment.
markdown: those links don't go anywhere like this. Random markdown cheatsheet suggests https://apps.dev.microsoft.com or <https://apps.dev.microsoft.com>
tests:
- https://apps.dev.microsoft.com (this is without anything)
- https://apps.dev.microsoft.com (this is wrapped in
<..>)
Documentation/microsoft-connector.md
Outdated
|
|
||
| ## Configuration | ||
|
|
||
| Register a new application on [https://apps.dev.microsoft.com]() via `Add an |
There was a problem hiding this comment.
same link thing (see above)
|
|
||
| ## Overview | ||
|
|
||
| One of the login options for dex uses the Microsoft OAuth2 flow to identify the |
There was a problem hiding this comment.
[nit] it sometimes says "dex" and sometimes "Dex" in here
connector/microsoft implements authorization strategy via Microsoft's OAuth2 endpoint + Graph API. It allows to choose what kind of tenants are allowed to authenticate in Dex via Microsoft: * common - both personal and business/school accounts * organizations - only business/school accounts * consumers - only personal accounts * <tenant uuid> - only account of specific tenant Signed-off-by: Pavel Borzenkov <[email protected]>
Microsoft connector now provides support for 'groups' claim in case 'tenant' is configured in Dex config for the connector. It's possible to deny user authentication if the user is not a member of at least one configured groups. Signed-off-by: Pavel Borzenkov <[email protected]>
|
🏓 @ericchiang I'm just an interested bystander, but I wonder if we could get this reviewed/approved? 😉 |
|
✅ I've just tested this against an Azure AD instance -- and it works as advertised 🎉 (Thanks again, @pborzenkov) |
ericchiang
approved these changes
Nov 28, 2017
There was a problem hiding this comment.
Thanks @srenatus for the review. I haven't tried this manually, but the code lgtm.
This was referenced Nov 29, 2017
Closed
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Implement Microsoft (Azure AD) connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connector provides an ability to authenticate in Dex via Microsoft with both personal and organization accounts. It's possible to restrict authentication based on the type of account or even to require accounts to belong to specific tenant.
Groups are also supported and will be queried if
groupsclaim is present in the request andtenantis configured in Dex configuration file. Groups support is not without caveats, though. See Documentation/microsoft-connector.md for details.