Merge pull request #1670 from klarose/handle-refresh-no-present

handlers: do not fail login if refresh token gone
dexidp · Mar 19, 2020 · 741bf02 · 741bf02
2 parents 2772725 + ab5ea03
commit 741bf02
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/handlers.go b/server/handlers.go
@@ -905,7 +905,7 @@ func (s *Server) handleAuthCode(w http.ResponseWriter, r *http.Request, client s
 		} else {
 			if oldTokenRef, ok := session.Refresh[tokenRef.ClientID]; ok {
 				// Delete old refresh token from storage.
-				if err := s.storage.DeleteRefresh(oldTokenRef.ID); err != nil {
+				if err := s.storage.DeleteRefresh(oldTokenRef.ID); err != nil && err != storage.ErrNotFound {
 					s.logger.Errorf("failed to delete refresh token: %v", err)
 					s.tokenErrHelper(w, errServerError, "", http.StatusInternalServerError)
 					deleteToken = true