feat(representation): add segment slider and pull to refresh #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thielpa
force-pushed
the
feat/ion-slider-ion-refresher
branch
from
018e9bf to
7a26a13
Compare
| }, | ||
| ]; | ||
| }); | ||
| if (refresher !== undefined) refresher.complete(); |
There was a problem hiding this comment.
Can be simplified to if (refresher)
thielpa
force-pushed
the
feat/ion-slider-ion-refresher
branch
from
7a26a13 to
1484b56
Compare
|
@devversion pr updated |
|
@Lordnoname Is pull to refresh still bugging? |
|
This is an issue from ionic 2. I can't fix that |
|
Okay, but then we should remove that, if it's still bugging. |
thielpa
force-pushed
the
feat/ion-slider-ion-refresher
branch
from
1484b56 to
7a5660e
Compare
|
@devversion I removed it.^ |
thielpa
force-pushed
the
feat/ion-slider-ion-refresher
branch
from
7a5660e to
93182f0
Compare
|
@devversion resolved conflicts. Ready for merge? |
thielpa
force-pushed
the
feat/ion-slider-ion-refresher
branch
from
93182f0 to
77e942b
Compare
update(): refresh each slide individually update(): remove buggy ion-spinner update(): improve slider and add loading window
thielpa
force-pushed
the
feat/ion-slider-ion-refresher
branch
from
77e942b to
9980611
Compare
|
@devversion Depends on #25 (angular-beta.4) |
|
Thanks for your reply, we will analyze your comment as soon as possible. |
|
|
||
| [hidden] { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Attribute Selectors are slow IE11
There was a problem hiding this comment.
Well.....good joke :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add segment slider and pull to refresh