misc: handler error while while helm deployment #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayu-devtron
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
ayu-devtron
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -782,6 +782,10 @@ | |||
| // Rollback tx on error. | |||
| defer tx.Rollback() | |||
| upgradeAppRequest, err = impl.updateInstalledApp(ctx, upgradeAppRequest, tx) | |||
| if err != nil { | |||
| impl.logger.Errorw("error while performing updateInstalledApp", "upgradeRequest", upgradeAppRequest, "err", err) | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 months ago
To fix the problem, we need to ensure that sensitive information is not logged in clear text. The best way to fix this issue without changing existing functionality is to remove the sensitive information from the log message or obfuscate it before logging.
- Identify the logging statement that logs the
upgradeAppRequestobject. - Remove or obfuscate the sensitive information (e.g., passwords) from the
upgradeAppRequestobject before logging it. - Ensure that the fix is applied to all relevant logging statements in the file.
Suggested changeset
1
pkg/appStore/installedApp/service/AppStoreDeploymentService.go
| @@ -566,2 +566,10 @@ | ||
|
|
||
| func sanitizeUpgradeAppRequest(request *appStoreBean.InstallAppVersionDTO) *appStoreBean.InstallAppVersionDTO { | ||
| sanitizedRequest := *request | ||
| if sanitizedRequest.InstallAppVersionChartDTO != nil && sanitizedRequest.InstallAppVersionChartDTO.InstallAppVersionChartRepoDTO != nil { | ||
| sanitizedRequest.InstallAppVersionChartDTO.InstallAppVersionChartRepoDTO.Password = "****" | ||
| } | ||
| return &sanitizedRequest | ||
| } | ||
|
|
||
| func (impl *AppStoreDeploymentServiceImpl) updateInstalledApp(ctx context.Context, upgradeAppRequest *appStoreBean.InstallAppVersionDTO, tx *pg.Tx) (*appStoreBean.InstallAppVersionDTO, error) { | ||
| @@ -785,3 +793,3 @@ | ||
| if err != nil { | ||
| impl.logger.Errorw("error while performing updateInstalledApp", "upgradeRequest", upgradeAppRequest, "err", err) | ||
| impl.logger.Errorw("error while performing updateInstalledApp", "upgradeRequest", sanitizeUpgradeAppRequest(upgradeAppRequest), "err", err) | ||
| return nil, err |
Copilot is powered by AI and may make mistakes. Always verify output.
vikramdevtron
approved these changes
Nov 14, 2024
ayu-devtron
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1257
Checklist:
Does this PR introduce a user-facing change?