Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding refchart migration #6007

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

badal773
Copy link
Contributor

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


vikramdevtron
vikramdevtron previously approved these changes Oct 21, 2024
Copy link

gitguardian bot commented Oct 21, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2763127 Triggered Generic High Entropy Secret 3616e20 scripts/devtron-reference-helm-charts/reference-chart_4-20-0/secrets-test-values.yaml View secret
9257608 Triggered Base64 AWS keys 3616e20 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 3616e20 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 3616e20 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 3616e20 scripts/devtron-reference-helm-charts/reference-chart_4-20-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret 3616e20 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret 3616e20 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

{{- if $.Values.topologySpreadConstraint }}
topologySpreadConstraints:
{{ toYaml .Values.topologySpreadConstraint }}
{{- end }}

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this Service Account to RBAC or disable "automountServiceAccountToken". See more on SonarCloud
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarCloud
{{- end}}
{{- else}}
-
{{ toYaml . | indent 10 }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
{{- end}}
{{- else}}
-
{{ toYaml . | indent 10 }}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarCloud
@pawan-mehta-dt pawan-mehta-dt merged commit b6cf6e8 into develop Oct 21, 2024
5 of 6 checks passed
@pawan-mehta-dt pawan-mehta-dt deleted the ref-chart-migration branch October 21, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants