Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore kubelink errors in server startup (#5852) #5854

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: ignore kubelink errors in server startup (#5852) #5854

merged 1 commit into from
Sep 17, 2024

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Sep 17, 2024 •
edited
Loading

  • fix: ignore error message got while checking devtron installation status

  • fix: correct error messaging for docker creds

Description

Fixes #5855

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gireesh-naidu
fix: ignore kubelink errors in server startup (#5852)
b10d483 
* fix: ignore error message got while checking devtron installation status

* fix: correct error messaging for docker creds
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gireesh-naidu gireesh-naidu linked an issue Sep 17, 2024 that may be closed by this pull request
Bug: orchestrator fail to start when kubelink is not in running state #5855
Closed
2 tasks
@gireesh-naidu gireesh-naidu merged commit 0fc6d64 into main Sep 17, 2024
18 of 26 checks passed
@gireesh-naidu gireesh-naidu deleted the installation-kubelink-error-main branch September 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Issue-verification-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: orchestrator fail to start when kubelink is not in running state
2 participants
@gireesh-naidu @vikramdevtron