Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster not reachable handling #2872

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

prakash100198
Copy link
Contributor

Description

When we click on the Resource Browser tab, there is no information about the cluster i.e if the cluster is active or has died on the upfront so that user can see it on the home page. So the error in connecting with the cluster is not being sent int hte api response for the frontend to handle.

How Has This Been Tested?

  • I tested my code locally, while checking the api response when we click on the Resource Browser tab

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manish-agrawal-ai manish-agrawal-ai merged commit eba0d65 into main Jan 19, 2023
@manish-agrawal-ai manish-agrawal-ai deleted the unreachable-cluster-handling branch January 19, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants