Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cluster terminal multiple image support #2815

Merged
merged 3 commits into from
Jan 2, 2023
Merged

feat: Cluster terminal multiple image support #2815

merged 3 commits into from
Jan 2, 2023

Conversation

kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Jan 2, 2023 •
edited
Loading

Description

Cluster terminal multiple images support added with images description and labels. Each image list comes with server version match regex.

Fixes #2814

How Has This Been Tested?

  • Tested with Kubernetes server version 1.25
  • Tested with Kubernetes server version 1.21

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kripanshdevtron kripanshdevtron self-assigned this Jan 2, 2023
@kripanshdevtron kripanshdevtron added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 2, 2023
@kripanshdevtron kripanshdevtron merged commit 119d1df into main Jan 2, 2023
@kripanshdevtron kripanshdevtron deleted the cluster-terminal-image-metadata branch January 2, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manish-agrawal-ai manish-agrawal-ai manish-agrawal-ai approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees

@kripanshdevtron kripanshdevtron

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Kubectl and Helm version in sync with Cluster Version
2 participants
@kripanshdevtron @manish-agrawal-ai