Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bitbucket gitops config fixes #2768

Merged
merged 17 commits into from
Jan 13, 2023
Merged

Conversation

vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Dec 14, 2022

Description

Issue 1468: Bitbucket gitops client missing config & refactoring

https://docs.google.com/document/d/1zR1De3uE9JKzZr9tsjTGtoQOqExD8UUtbD_xYHLfBzo/edit?usp=sharing

Fixes https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/1468

How Has This Been Tested?

  • 1) Make sure no bitbucket gitops configured, remove from database if already exists with disabled state. go ahead with other gitops configurations.
  • 2) Create devtron apps [Create Deployment template, Cd pipeline create via ACD, CD Trigger], also [Update Cd pipeline, re Trigger, Delete ]
  • 3) Create helm apps [Deploy via ACD], also update and Deploy and Delete.
  • 4) Now change gitops global config, add Bitbucket configs and validate and save.
  • 5) Now try to repeat step 2 and 3 for New apps.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@vikramdevtron vikramdevtron self-assigned this Dec 14, 2022
@gitguardian
Copy link

gitguardian bot commented Dec 14, 2022

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret c2be4ab scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/env-values.yaml View secret
2763127 Generic High Entropy Secret c2be4ab scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/secrets-test-values.yaml View secret
5236769 Generic High Entropy Secret c2be4ab scripts/devtron-reference-helm-charts/deployment-chart_1-0-0/test-values.json View secret
141558 Generic High Entropy Secret 3f92ede scripts/devtron-reference-helm-charts/cronjob-chart_1-4-0/env-values.yaml View secret
2763127 Generic High Entropy Secret 3f92ede scripts/devtron-reference-helm-charts/cronjob-chart_1-4-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

kartik-579
kartik-579 previously approved these changes Dec 23, 2022
@vikramdevtron vikramdevtron merged commit 1154c76 into main Jan 13, 2023
@vikramdevtron vikramdevtron deleted the hotfix-bitbucket-gitops branch January 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants