Ingress Urls User level access Issue #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/restHandler/AppListingRestHandler.go
gireesh-naidu
requested review from
nishant-d and
kripanshdevtron
and removed request for
nishant-d
kripanshdevtron
changed the title
| appId, err := strconv.Atoi(appIdParam) | ||
| if err != nil { | ||
| handler.logger.Errorw("error in parsing appId from request body", "appId", appIdParam, "err", err) | ||
| common.WriteJsonResp(w, fmt.Errorf("error in parsing appId : %s must be integer", envIdParam), nil, http.StatusBadRequest) |
There was a problem hiding this comment.
use appIdParam instead of envIdParam
| return | ||
| } | ||
| } else { | ||
| object := handler.enforcerUtil.GetAppRBACNameByAppId(appId) |
There was a problem hiding this comment.
do we still need to check again??
kripanshdevtron
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the access denied issue while fetching urls of service and manifest for non super-admins.
Fixes #2660
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
test-cases
Checklist:
Does this PR introduce a user-facing change?