Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:updated ciBuildType check in app create #2652

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Nov 17, 2022

Description

Updated check for build type in app create api for buildpack story backward compatibility.

Fixes #2653

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@kripanshdevtron kripanshdevtron merged commit c51738f into main Nov 17, 2022
@kripanshdevtron kripanshdevtron deleted the app-create-hotfix branch November 17, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Ci build fails in app created from api
2 participants