fix: checking git material active status for multiple places : 1) while triggering ci 2) while getting commit info 3) while getting ci pipeline #2636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an app is using multiple git repositories and if someone deletes a git repository from those, workflow doesn't get updated with the changes. It keeps showing the same git repositories which were before deletion of any one of them.
Even if you add the same repo again, Workflow doesn't update the id for the same. Triggered ci pipeline with multiple git repositories and when one of the git material is deleted, it should have affected multiple places but deletion was not reflecting at all anywhere.
Places where git material deletion should be reflected are:-
Deleted git repository node will be removed
Current Behavior:- Git material deleted in the git repositories section but it still appears in the pipeline.
Deleted git repositoryke node will be removed
Current Behavior:- Git material deleted in the git repositories section but it still appears in the pipeline.
Deleted git repository should not be shown as an option here.
Current Behavior:- Git material deleted in the git repositories section but it still appears in the source code options.
Deleted git repository will not be shown for commit selection
Current Behavior:- Git material deleted in the git repositories section but it still appears as an option in the select material section.
Only those “repo + commits” will be shown which were used to build the image
Current Behavior:- Git material deleted in the git repositories section but it still appears in the source info in deployment
card.
For each triggered build, show the state at that point of time I.e. If 2 repos were connected during the build trigger, 2
repos and the selected commits will be shown. Later if the user removed a repo and triggered a build, only 1 repo will be
shown against that build trigger.
Current Behavior:- Builds triggered with one git repertory, also shows history of 2nd git material, which was deleted from
the git repositories.
For each triggered deployment, show only those “repo + commits” which were used to build the deployed image.
Current Behavior:- Deployments triggered with one git repertory, also shows history of 2nd git material, which was deleted
from the git repositories.
As this is the current state of a deployed commit(which commits are being deployed from which git material), if
deployment is triggered by 2 git material then 2 git materials should reflect here, else if there is only one then only 1 git
material should reflect here.
Fixes #1397
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?