Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sql script semicolon fix #2590

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

prakash100198
Copy link
Contributor

Description

Fixed the semicolon missing in sql scripts

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested locally.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@manish-agrawal-ai manish-agrawal-ai merged commit cf7b614 into main Nov 7, 2022
@manish-agrawal-ai manish-agrawal-ai deleted the db-migration-fix-for-chart-ref branch November 7, 2022 09:37
pawan-59 added a commit that referenced this pull request Nov 9, 2022
* fixed migration query in 90th migration (#2586)

* updated wiring for TelemetryEventClientExtended.go (#2588)

* feat: Provide description for Chart Types (#2585)

* chart description provided with the api call

* added code to provide chart description with the api call

* refined the code for poviding chart description

* mitigated nil pointer exception in ChartService

* refactoring

* changes in sql files

Co-authored-by: Manish Agrawal <[email protected]>

* sql script semicolon fix (#2590)

* Ci Build config API backward compatibilty (#2598)

* docker build config added as backward compatible changes

* dependency injection fix

Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Prakash Kumar <[email protected]>
Co-authored-by: Manish Agrawal <[email protected]>
Co-authored-by: kripanshdevtron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants