fix: panic handling for get workflow logs (#6168)

* panic handling * error panic * cd logs panic handle
devtron-labs · Dec 13, 2024 · c3f68db · c3f68db
1 parent b37bf8d
commit c3f68db
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go b/api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go
@@ -1191,7 +1191,11 @@ func (handler *PipelineConfigRestHandlerImpl) GetBuildLogs(w http.ResponseWriter
 		}(ctx.Done(), cn.CloseNotify())
 	}
 	defer cancel()
-	defer cleanUp()
+	defer func() {
+		if cleanUp != nil {
+			cleanUp()
+		}
+	}()
 	handler.streamOutput(w, logsReader, lastSeenMsgId)
 }
 

diff --git a/api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go b/api/restHandler/app/pipeline/configure/DeploymentPipelineRestHandler.go
@@ -1808,7 +1808,11 @@ func (handler *PipelineConfigRestHandlerImpl) GetPrePostDeploymentLogs(w http.Re
 		}(ctx.Done(), cn.CloseNotify())
 	}
 	defer cancel()
-	defer cleanUp()
+	defer func() {
+		if cleanUp != nil {
+			cleanUp()
+		}
+	}()
 	handler.streamOutput(w, logsReader, lastSeenMsgId)
 }
 

diff --git a/pkg/pipeline/CiHandler.go b/pkg/pipeline/CiHandler.go
@@ -825,7 +825,7 @@ func (impl *CiHandlerImpl) GetRunningWorkflowLogs(workflowId int) (*bufio.Reader
 
 func (impl *CiHandlerImpl) getWorkflowLogs(ciWorkflow *pipelineConfig.CiWorkflow) (*bufio.Reader, func() error, error) {
 	if string(v1alpha1.NodePending) == ciWorkflow.PodStatus {
-		return bufio.NewReader(strings.NewReader("")), nil, nil
+		return bufio.NewReader(strings.NewReader("")), func() error { return nil }, nil
 	}
 	ciLogRequest := types.BuildLogRequest{
 		PodName:   ciWorkflow.PodName,