fix: add catch blocks to fetch calls

Changes in appDetails/AppDetails.tsx, details/main.tsx & appDetails/AppDetails.component.tsx
devtron-labs · Feb 23, 2024 · 831179f · 831179f
1 parent 8d78097
commit 831179f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/src/components/app/details/appDetails/AppDetails.tsx b/src/components/app/details/appDetails/AppDetails.tsx
@@ -334,7 +334,9 @@ export const Details: React.FC<DetailsType> = ({
                     }
                 },
             )
-            .catch(noop)
+            .catch((error) => {
+              showError(error)
+            })
         },
         [
             params.appId,

diff --git a/src/components/app/details/main.tsx b/src/components/app/details/main.tsx
@@ -8,7 +8,6 @@ import {
     ToastBody,
     DeleteDialog,
     ErrorScreenManager,
-    noop,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { MultiValue } from 'react-select'
 import { toast } from 'react-toastify'
@@ -111,9 +110,9 @@ export default function AppDetailsPage({ isV2 }: AppDetailsProps) {
             setGroupFilterOptions(_groupFilterOption)
           }
         } catch (error) {
-          noop;
+          showError(error)
         }
-      setAppListLoading(true)
+        setAppListLoading(false)
     }
 
     const getAppListData = async (): Promise<void> => {
@@ -133,7 +132,9 @@ export default function AppDetailsPage({ isV2 }: AppDetailsProps) {
               .sort(sortOptionsByLabel),
             )
           }
-        } catch (error) {noop}
+        } catch (error) {
+          showError(error)
+        }
         setAppListLoading(false)
     }
 

diff --git a/src/components/v2/appDetails/AppDetails.component.tsx b/src/components/v2/appDetails/AppDetails.component.tsx
@@ -1,7 +1,7 @@
 import React, { useEffect, useRef, useState } from 'react'
 import './appDetails.scss'
 import { useLocation, useParams } from 'react-router'
-import { DeploymentAppTypes, Progressing, noop } from '@devtron-labs/devtron-fe-common-lib'
+import { DeploymentAppTypes, Progressing, showError } from '@devtron-labs/devtron-fe-common-lib'
 import { AppDetailsComponentType, AppStreamData, AppType } from './appDetails.type'
 import IndexStore from './index.store'
 import EnvironmentStatusComponent from './sourceInfo/environmentStatus/EnvironmentStatus.component'
@@ -106,7 +106,9 @@ const AppDetailsComponent = ({
                 }
             },
         )
-        .catch(noop)
+        .catch((error) => {
+          showError(error)
+        })
     }
 
     const processDeploymentStatusData = (deploymentStatusDetailRes: DeploymentStatusDetailsType): void => {