Allow sending streams and not just receiving them #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsociety
reviewed
Apr 17, 2024
| /** | ||
| * Send a message to a pod and receive a stream of replies | ||
| */ | ||
| def sendMessageStreaming(pod: PodAddress, message: BinaryMessage): ZStream[Any, Throwable, Array[Byte]] | ||
| def sendMessageAndReceiveStream(pod: PodAddress, message: BinaryMessage): ZStream[Any, Throwable, Array[Byte]] |
There was a problem hiding this comment.
Any particular reason to diverge the wording between sendMessageAndReceiveStream and sendAndReceiveStream?
There was a problem hiding this comment.
Mostly to avoid renaming existing sendMessage which would increase breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messengernow has 4 different ways of sending a message:sendfor sending a single message and receiving a single responsesendStreamfor sending a stream of messages without receiving any responsesendAndReceiveStreamfor sending a single message and receiving a stream of responses (was previously namedsendStream)sendStreamAndReceiveStreamfor sending a stream of messages and receiving a stream of responses