Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for source archives #59

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

tranzystorekk
Copy link
Contributor

@tranzystorekk tranzystorekk commented Nov 3, 2022

Closes #52

Adding as draft to initiate discussion.

Important notes:

  • switched the url used for normal assets to browser_download_url to make the common accepted content type application/vnd.github.raw work uniformly
  • the progress bar displays just the downloaded bytes if the content length is unknown
  • skipped implementing this feature for untag for now

Copy link
Owner

@devmatteini devmatteini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tranzystorek-io! Thanks for the PR 🔝

I left some comments to check out :)

src/cli/progress_bar.rs Show resolved Hide resolved
src/cli/handlers/download.rs Show resolved Hide resolved
src/github/release.rs Show resolved Hide resolved
@devmatteini
Copy link
Owner

Hi @tranzystorek-io!
I was testing this changes a bit more and noticed that the progress bar was not rendering as soon as you selected an asset like it currently does.

I already pushed a fix for it :)

Apart from that, I think we can merge this PR

@devmatteini devmatteini marked this pull request as ready for review November 6, 2022 17:31
@devmatteini devmatteini merged commit a9d4d12 into devmatteini:main Nov 6, 2022
@tranzystorekk tranzystorekk deleted the source-downloads branch November 6, 2022 17:34
@devmatteini
Copy link
Owner

I still need to do some cleanup after the cross-platform release, but I think I will release a new version with these changes pretty soon :)

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Nov 7, 2022

No probs, I wanted to have this officially packaged for Void Linux, but at least for now the maintainers don't see it add much value over gh 🫤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for source code archives
2 participants