cli+github: show download progress #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmatteini
requested changes
May 8, 2022
There was a problem hiding this comment.
HI @orhun! Thanks for this contribution 🚀
I left a couple of comments to check out 😄 .
The spinner implementation has been improved to show the remaining and total amount of bytes to download Signed-off-by: Orhun Parmaksız <[email protected]>
orhun
force-pushed
the
show_download_progress
branch
from
bf3873a to
3fa30db
Compare
devmatteini
approved these changes
May 9, 2022
|
Nice work @orhun! |
|
Here's the refactoring of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17
P.S. feel free to try out different templates for the progress bar and let me know if this one fits 🐻