Use portable PDB in separate NuGet symbol package #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
changed the title
|
Changed this PR's status to "work in progress" because AppVeyor apparently does not yet support pushing |
|
AppVeyor still doesn't support |
We want to continue publishing SourceLink-ed debug symbols, but using classic Windows PDBs generates a huge package. Using the much smaller portable PDB format would be much better, but some people may still experience problems with those. (See e.g. GitHub issue devlooped#428.) Let's follow the official guidance (see links below) and publish debug symbols in a separate `.snupkg` package to NuGet's symbol server. This means that we can (must, in fact) use portable PDBs as it will be the consumers' choice whether to use the separate symbols or not. References: * https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg * https://github.com/dotnet/SourceLink#alternative-pdb-distribution
ctaggart's SourceLink has at some point started packing `.pdb` files into the main Nuget package, which is not ideal if we want to publish a separate `.snupkg` to NuGet. For that reason, let's make the switch to `dotnet/SourceLink` even though it is *still* only in beta. References: * ctaggart/SourceLink#291
stakx
changed the title
|
This looks good as far as I can see, but I'll have to run a final test and actually publish to NuGet (as another pre-release). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to continue publishing SourceLink-ed debug symbols, but using classic Windows PDBs generates a huge package. Using the much smaller portable PDB format would be much better, but some people may still experience problems with those. (See e.g. GitHub issue #428.)
Let's follow the official guidance (see links below) and publish debug symbols in a separate
.snupkgpackage to NuGet's symbol server. This means that we can (must, in fact) use portable PDBs as it will be the consumers' choice whether to use the separate symbols or not.Closes #447.
References: