Add tests for Moq compatibility with F# events #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two old Google Code issues which were resolved with commit 44070a9, however no documentation or unit tests were ever added for these issues: * Moq fails to mock events defined in F#: https://code.google.com/archive/p/moq/issues/238 * Can't raise events on mocked Interop interfaces: https://code.google.com/archive/p/moq/issues/226 This commit adds unit tests for the first of these two issues by add- ing an F# test project to the solution, which allows us to define F# types for use in unit tests.
stakx
commented
Oct 28, 2018
stakx
commented
Oct 28, 2018
|
👍! |
stakx
added a commit
to stakx/moq
that referenced
this pull request
Nov 4, 2018
This is a follow-up to devlooped#712 and devlooped#713, where we added tests documenting F# and COM events not being marked with the IL `specialname` flag. But as it turns out, F# and COM *properties* are marked as `specialname`, which we document here using unit tests. Finally, we bring back checks for `method.IsSpecialName` for property accessor method recognition.
stakx
added a commit
to stakx/moq
that referenced
this pull request
Nov 4, 2018
This is a follow-up to devlooped#712 and devlooped#713, where we added tests documenting F# and COM events not being marked with the IL `specialname` flag. But as it turns out, F# and COM *properties* are marked as `specialname`, which we document here using unit tests. Finally, we bring back checks for `method.IsSpecialName` for property accessor method recognition.
stakx
added a commit
to stakx/moq
that referenced
this pull request
Nov 4, 2018
This is a follow-up to devlooped#712 and devlooped#713, where we added tests documenting F# and COM events not being marked with the IL `specialname` flag. But as it turns out, F# and COM *properties* are marked as `specialname`, which we document here using unit tests. Finally, we bring back checks for `method.IsSpecialName` for property accessor method recognition.
stakx
added a commit
to stakx/moq
that referenced
this pull request
Nov 4, 2018
This is a follow-up to devlooped#712 and devlooped#713, where we added tests documenting F# and COM events not being marked with the IL `specialname` flag. But as it turns out, F# and COM *properties and indexer* accessor methods are marked as `specialname`, which we document here using unit tests. Finally, we bring back checks for `method.IsSpecialName` for property and indexer accessor method recognition.
stakx
added a commit
that referenced
this pull request
Nov 4, 2018
This is a follow-up to #712 and #713, where we added tests documenting F# and COM events not being marked with the IL `specialname` flag. But as it turns out, F# and COM *properties and indexer* accessor methods are marked as `specialname`, which we document here using unit tests. Finally, we bring back checks for `method.IsSpecialName` for property and indexer accessor method recognition.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two old Google Code issues which were resolved with commit 44070a9, however no documentation or unit tests were ever added for these issues:
Moq fails to mock events defined in F#:
https://code.google.com/archive/p/moq/issues/238
Can't raise events on mocked Interop interfaces:
https://code.google.com/archive/p/moq/issues/226
This commit adds unit tests for the first of these two issues by adding an F# project to the solution, which allows us to define F# types for use in unit tests.
Some of these tests are skipped on purpose; see dotnet/fsharp#5834.