Push to NuGet on tag, not on commit to master branch #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on a separate
develop
branch rather than directly onmaster
has had one big benefit, namely that not every PR merge or other commit immediately triggered a new NuGet package release. We could prepare the next release ondevelop
, and then merge intomaster
to publish. However, maintaining two branches introduced its own problems, e.g.:It is hard to predict the version number to be put into
CHANGELOG.md
, sincemaster
has additional merge commits thatdevelop
doesn't have, so GitInfo arrives at a different (later) version number onmaster
.The
master
branch is still set up as default, so PRs are often made against the wrong branch.This PR is a first step towards a different publish procedure: If all goes as planned, we can permanently merge
develop
intomaster
and abandon it. Commits onmaster
will no longer automatically trigger a NuGet push, only pushing a tag will have that effect. This is especially nice since we're already tagging release commits.