Skip to content

Push to NuGet on tag, not on commit to master branch #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Sep 30, 2017

Working on a separate develop branch rather than directly on master has had one big benefit, namely that not every PR merge or other commit immediately triggered a new NuGet package release. We could prepare the next release on develop, and then merge into master to publish. However, maintaining two branches introduced its own problems, e.g.:

  • It is hard to predict the version number to be put into CHANGELOG.md, since master has additional merge commits that develop doesn't have, so GitInfo arrives at a different (later) version number on master.

  • The master branch is still set up as default, so PRs are often made against the wrong branch.

This PR is a first step towards a different publish procedure: If all goes as planned, we can permanently merge develop into master and abandon it. Commits on master will no longer automatically trigger a NuGet push, only pushing a tag will have that effect. This is especially nice since we're already tagging release commits.

@stakx stakx changed the title Deployment: switch from 'push on master' to 'push on tag' Push to NuGet on tag, not on commit to master branch Sep 30, 2017
@stakx stakx merged commit 03bbf8b into devlooped:develop Sep 30, 2017
@stakx stakx deleted the appveyor branch September 30, 2017 18:34
@devlooped devlooped locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant