Refactor EFB switching #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EFB copy operation is not clearing the EFB, so setting the clear color and Z-value here does not have any effect.
Refactor the existing code in stencil.c, where the EFB was saved and later restored when switching between the stencil and scene drawing targets, to make it more generic and able to support more drawing targets. Now there is a centralized function, _ogx_efb_set_content_type(), which will take care of invoking the right functions to save the current EFB contents to the appropriate buffer, as well as to load the target buffer (and set it up, if it had not been used before). This will allow us to more easily support the accumulation buffer (see the glAccum function).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the existing code in stencil.c, where the EFB was saved and later restored when switching between the stencil and scene drawing targets, to make it more generic and able to support more drawing targets. Now there is a centralized function, _ogx_efb_set_content_type(), which will take care of invoking the right functions to save the current EFB contents to the appropriate buffer, as well as to load the target buffer (and set it up, if it had not been used before).
This will allow us to more easily support the accumulation buffer (see the glAccum function).