-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go version to 1.23 #157
Conversation
c0b2478
to
c3a5e4a
Compare
Note: Once merged we'll need to cut a new release with version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I noticed it seems like there is some old commits in this PR - I wonder if the branch needs a rebase?
52a809a
to
025e0e5
Compare
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
025e0e5
to
88f5a73
Compare
yeah I cleaned my main branch in my fork a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, failing check for scoreboard is automatic because of a deprecated dep so we'll need an issue opened to address that. I can open the issue for it fyi @thepetk
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: thepetk <[email protected]>
New changes are detected. LGTM label has been removed. |
I've bumped up for alizer to |
devfile/api#1675 for reference |
Description of Changes
Simply upgrades the go version of alizer to 1.23
Related Issue(s)
partially fixes devfile/api#1671
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.