Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.23 #157

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Upgrade go version to 1.23 #157

merged 4 commits into from
Jan 23, 2025

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jan 22, 2025

Description of Changes

Simply upgrades the go version of alizer to 1.23

Related Issue(s)

partially fixes devfile/api#1671

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

  • Unit/Functional tests

  • Documentation

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@thepetk
Copy link
Contributor Author

thepetk commented Jan 22, 2025

Note: Once merged we'll need to cut a new release with version v1.7.0

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I noticed it seems like there is some old commits in this PR - I wonder if the branch needs a rebase?

.github/workflows/release.yaml Outdated Show resolved Hide resolved
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk
Copy link
Contributor Author

thepetk commented Jan 23, 2025

Overall looks good, I noticed it seems like there is some old commits in this PR - I wonder if the branch needs a rebase?

yeah I cleaned my main branch in my fork a bit

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, failing check for scoreboard is automatic because of a deprecated dep so we'll need an issue opened to address that. I can open the issue for it fyi @thepetk

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: thepetk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jan 23, 2025
Copy link

openshift-ci bot commented Jan 23, 2025

New changes are detected. LGTM label has been removed.

@thepetk
Copy link
Contributor Author

thepetk commented Jan 23, 2025

lgtm, failing check for scoreboard is automatic because of a deprecated dep so we'll need an issue opened to address that. I can open the issue for it fyi @thepetk

I've bumped up for alizer to v4.6.0 but I do feel an issue needs to be created as we'll need to do this across all our repos

@thepetk thepetk merged commit 72d50fe into devfile:main Jan 23, 2025
8 checks passed
@Jdubrick
Copy link
Contributor

lgtm, failing check for scoreboard is automatic because of a deprecated dep so we'll need an issue opened to address that. I can open the issue for it fyi @thepetk

I've bumped up for alizer to v4.6.0 but I do feel an issue needs to be created as we'll need to do this across all our repos

devfile/api#1675 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go modules to 1.23
2 participants