Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove defaults in deps and add .as_dict method to the DefaultDependency class #819

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented May 25, 2024

This PR does:

  • remove defaults to most of dependencies (and default to rio-tiler values)
  • In order to defaults to rio-tiler's default we have to NOT pass options to rio-tiler's method. when we use Dependency unpacking we would pass value=None, to overcome this, we introduce a new .as_dict() method which will return a Dict from the dependency but only with non-None values

@vincentsarago

This comment was marked as outdated.

@vincentsarago vincentsarago changed the title remove defaults in deps and add kwargs property remove defaults in deps and add .as_dict method to the DefaultDependency class Jul 5, 2024
@vincentsarago vincentsarago merged commit bce7c75 into main Jul 9, 2024
10 checks passed
@vincentsarago vincentsarago deleted the feature/remote-defaults-in-deps branch July 9, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant