TST: use app, client fixture to reuse in tests #1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return TestClient(app) | ||
|
|
||
|
|
||
| def test_lowercase_middleware(app, client): |
There was a problem hiding this comment.
We don't need the app fixture here then
There was a problem hiding this comment.
ah no we need it, But then it's a bit weird that we register the endpoint after creating the application 😬
There was a problem hiding this comment.
That's correct, we can leave it as it is and close this PR if the change doesn't seem clean enough.
There was a problem hiding this comment.
Yeah I'm not convinced we need this change, sorry 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentsarago – thoughts on reusing fixtures? Reduces the need to keep defining client in every case.