Fallback to layer id and use urn identifier in tms supportedCRS #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,7 +113,7 @@ | |||
| {% for tms in tilematrixsets %} | |||
| <TileMatrixSet> | |||
| <ows:Identifier>{{ tms.id }}</ows:Identifier> | |||
| <ows:SupportedCRS>{{ tms.crs.srs }}</ows:SupportedCRS> | |||
| <ows:SupportedCRS>urn:ogc:def:crs:{{ tms.id }}</ows:SupportedCRS> | |||
There was a problem hiding this comment.
this is not valid, a TMS identifier is not always a valid SRS/CRS string
what we could do is use tms.crs.to_epsg()
{% if tms.crs.to_epsg() %}
<ows:SupportedCRS>urn:ogc:def:crs:epsg::{{tms.crs.to_epsg()}}</ows:SupportedCRS>
{% else %}
<ows:SupportedCRS>{{ tms.crs.srs.replace("http://www.opengis.net/def/", "urn:ogc:def:").replace("/", ":")}} </ows:SupportedCRS>
{% endif %}
There was a problem hiding this comment.
Ok, modified it in PR
There was a problem hiding this comment.
we don't have tests for the WMTS endpoint so could you tests those change before we merge?
vincentsarago
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to layer id if the title is empty because some capability parsers use this ows:Title as the identifier.
Use urn identifier in TMS supportedCRS as this is following the WMTS spec. Also found some processor failing on the srs. Spec example: https://schemas.opengis.net/wmts/1.0/examples/wmtsGetCapabilities_response.xml