Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #105
Well, this is way more complex than I originally thought.
I'm interested in having basic request metrics for an object store: number of requests, their type (get/list/put/delete), timing, and number of bytes downloaded.
At first I was thinking of doing this with a simple
Mutex<Vec<RequestStatistics>>
, but realized it would lead to horrible lock contention when each request wants to append to the vec.So I've been looking at the
tracing
crate and itsInstrument
, which looks like it might perform better for async code.However it looks like that's considerably more complex than I want to get into right now.
In theory, a mature implementation of this would allow the Python user to choose where the traces actually go. Like you could set this up to use ObjectStore but send tracing information to, say, CloudWatch
I'll put this stub up just to record my thoughts.