Skip to content

Commit

Permalink
Add to CI: Ensure docs build without warnings (#229)
Browse files Browse the repository at this point in the history
* Add ci test for docs

* remove middleware doc

* small edits
  • Loading branch information
kylebarron authored Feb 6, 2025
1 parent 645a301 commit 5a84390
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/test-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,8 @@ jobs:
- name: Run python tests
run: |
uv run pytest tests
# Ensure docs build without warnings
- name: Check docs
if: "${{ matrix.python-version == 3.11 }}"
run: uv run mkdocs build --strict
3 changes: 0 additions & 3 deletions docs/api/store/middleware.md

This file was deleted.

4 changes: 2 additions & 2 deletions obstore/python/obstore/fsspec.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def __init__(
store: obs.store.ObjectStore,
*args,
asynchronous: bool = False,
loop=None,
loop: Any = None,
batch_size: int | None = None,
):
"""Construct a new AsyncFsspecStore
Expand Down Expand Up @@ -192,7 +192,7 @@ def read(self, length: int = -1):
Args:
length: if positive, returns up to this many bytes; if negative, return all
remaining byets.
remaining byets.
"""
if length < 0:
data = self.fs.cat_file(self.path, self.loc, self.size)
Expand Down

0 comments on commit 5a84390

Please sign in to comment.